[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc49fbd2df7d: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D149443

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 533190. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp llvm/include/

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/test/MC/ARM/thumb-fixups.s:1 +@ RUN: llvm-mc -triple armv6m-unknown-unknown %s --show-encoding > %t +@ RUN: FileCheck < %t %s We normally just pipe the output to FileCheck, e.g. `| Fi

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 532685. stuij marked 3 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 Files: clang/lib/Driv

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

MaskRay added inline comments. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:1244 +int64_t Value = CE->getValue(); +return Value >= 0 && Value < 256; + } `isUInt<8>(Value)`. Can the limit be tested? Comment at: llvm/test/

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

MaskRay added inline comments. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6422 + // consume an optional trailing '#' (GNU compatibility) + if (getLexer().is(AsmToken::Hash)) +Parser.Lex(); Use `parseOptionalToken`. Repository: rG LLVM G

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 ___

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij added a comment. In D149443#4403186 , @john.brawn wrote: > A few comments: > > - Please run clang-format on the patch (pre-merge is showing as failed due to > this) > - We should have a test to check that we're emitting the right relocation > (pr

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 531792. stuij marked 2 inline comments as done. stuij added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l