[PATCH] D149380: [clang] Add -Wunused-result-always warning

2023-05-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D149380#4311237 , @dblaikie wrote: > Seems more stylistic/unlikely to meet the diagnostic bar (certtainly couldn't > be on-by-default for instance) for clang to me (but could go into something > like clang-tidy), at lea

[PATCH] D149380: [clang] Add -Wunused-result-always warning

2023-05-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Seems more stylistic/unlikely to meet the diagnostic bar (certtainly couldn't be on-by-default for instance) for clang to me (but could go into something like clang-tidy), at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D149380: [clang] Add -Wunused-result-always warning

2023-04-28 Thread Gregory Anders via Phabricator via cfe-commits
gpanders updated this revision to Diff 518024. gpanders added a comment. Remove cast to (void) in unused-expr.c This cast is not necessary for this test, because foo does not have a "warn_unused_result" attribute and is not marked const or pure. Removing the cast improves the usefuless of the tes

[PATCH] D149380: [clang] Add -Wunused-result-always warning

2023-04-27 Thread Gregory Anders via Phabricator via cfe-commits
gpanders created this revision. gpanders added a reviewer: theraven. Herald added a project: All. gpanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag enables warnings for unused function return values universally, even for fu