Re: [PATCH] D14935: Fix nodefaultlibs/nostdlib check

2015-11-24 Thread Nirav Dave via cfe-commits
niravd updated this revision to Diff 41040. niravd added a comment. Fix review issues http://reviews.llvm.org/D14935 Files: lib/Driver/Driver.cpp test/Driver/nodefaultlib.c Index: test/Driver/nodefaultlib.c === --- test/Driver

[PATCH] D14935: Fix nodefaultlibs/nostdlib check

2015-11-24 Thread Nirav Dave via cfe-commits
niravd created this revision. niravd added reviewers: dougk, jyknight. niravd added subscribers: cfe-commits, rsmith. Checks for nostdlib should also always check nodefaultlibs or nostartfiles as appropriate. Clang Driver misses a case http://reviews.llvm.org/D14935 Files: lib/Driver/Driver.c

Re: [PATCH] D14935: Fix nodefaultlibs/nostdlib check

2015-11-23 Thread James Y Knight via cfe-commits
jyknight added a comment. The commit message could use some work: please summarize what you're actually changing, and why. (Here you mention only vaguely why, and not what.) Comment at: test/Driver/nodefaultlib_stdc.c:1 @@ +1,2 @@ +// RUN: %clang -stdlib=libc++ -nodefaultlibs -