[PATCH] D149272: [clang] Call printName to get name of Decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGea6ecdbfe09d: Call printName to get name of Decl (authored by dankm, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D149272?vs=518050&id=518761#toc Repository: rG LLVM

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. In D149272#4306103 , @aaron.ballman wrote: > LGTM, but please add a release note when landing. Thanks, I do not have permission to land, are you able to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 518050. dankm added a comment. Rebase & add add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Decl.

[PATCH] D149272: [clang] Call printName to get name of Decl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.o

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 517595. dankm added a comment. Correct test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/lib/AST/Decl.cpp clang/lib/AST/DeclarationName.cpp c

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.cpp:1 +// RUN: %clang++ -g -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-REL + dankm wrote: > aaron.ballman wrote: > > I'm tak

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.cpp:1 +// RUN: %clang++ -g -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-REL + aaron.ballman wrote: > I'm taking a guess at co

[PATCH] D149272: [clang] Call printName to get name of Decl

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclarationName.cpp:119-125 if (const RecordType *ClassRec = ClassType->getAs()) { -OS << *ClassRec->getDecl(); +ClassRec->getDecl()->printName(OS, Policy); return; } if (Policy.SuppressTemplateA

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. In D149272#4301103 , @raj.khem wrote: > This would fix https://github.com/llvm/llvm-project/issues/62192 Thanks. I didn't know that was created. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D149272: [clang] Call printName to get name of Decl

raj.khem added a comment. This would fix https://github.com/llvm/llvm-project/issues/62192 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 ___ cfe-commits maili

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 517427. dankm added a comment. And restore original change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/lib/AST/Decl.cpp clang/lib/AST/DeclarationNa

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 517426. dankm added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/test/CodeGen/debug-prefix-map.cpp Index: clang/test/CodeGe

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. Hoorat for me. I just managed to produce a reduced test case. That'll be added to the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 __

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/lib/AST/DeclarationName.cpp:119-125 if (const RecordType *ClassRec = ClassType->getAs()) { -OS << *ClassRec->getDecl(); +ClassRec->getDecl()->printName(OS, Policy); return; } if (Policy.SuppressTemplateArgsInCXX

[PATCH] D149272: [clang] Call printName to get name of Decl

aaron.ballman added a comment. Thank you for working on this! Please be sure to add a release note and test coverage for the changes. Comment at: clang/lib/AST/DeclarationName.cpp:119-125 if (const RecordType *ClassRec = ClassType->getAs()) { -OS << *ClassRec->getDecl()

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. This fixes and issue I wasn't able to reduce. Some lambdas wound up with the real filename in their name, rather than the remapped path from -ffile-prefix-map. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm created this revision. dankm added a reviewer: MaskRay. Herald added a project: All. dankm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rather than sending a name directly to the stream, use printName to preserve any PrintingPolicy