[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

2019-11-01 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. This I believe is covered by `SpaceAfterTemplateKeyword` which does the same thing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14927/new/ https://reviews.llvm.org/D14927 ___ cfe-commits mailing list cfe-co

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

2019-10-31 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: include/clang/Format/Format.h:500 + /// bracket of a template parameter list. + bool SpaceBeforeTemplateParameterList; + I suggest we make this an enumeration ``` enum { Unaltered, Never, Always, } ``` Introdu

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

2019-10-30 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Style guide suggesting enforcing a space after template keyword https://mesos.readthedocs.io/en/1.1.0/c++-style-guide/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14927/new/ https://reviews.llvm.org/D14927 ___

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

2019-10-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. This revision would require unit tests to proceed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14927/new/ https://reviews.llvm.org/D14927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

Re: [PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

2015-11-23 Thread Daniel Jasper via cfe-commits
djasper added a subscriber: djasper. djasper added a comment. This has come up before (read up on the list) and the decision is not to support it. In short, this is so un-important, that it is not worth a configuration option. http://reviews.llvm.org/D14927 _

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

2015-11-23 Thread Nico Rieck via cfe-commits
nrieck created this revision. nrieck added a subscriber: cfe-commits. Herald added a subscriber: klimek. Adds an option to control whether a space is inserted between "template" and "<". Currently a space is always inserted (as the LLVM style requires), but to me this seems like the less popular