Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

2015-11-24 Thread Vasileios Kalintiris via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253972: Use libcxx's default rune table with the Musl C library. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D14926?vs=40926&id=41016#toc Repository: rL LLVM http://r

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

2015-11-23 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/__locale:411-415 @@ -410,7 +410,3 @@ #else -#if defined(_LIBCPP_HAS_MUSL_LIBC) -typedef unsigned short mask; -#else typedef unsigned lon

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

2015-11-23 Thread Vasileios Kalintiris via cfe-commits
vkalintiris added a comment. @dalias: Can you take a correctness-look at this patch? Comment at: include/__locale:411-415 @@ -410,7 +410,3 @@ #else -#if defined(_LIBCPP_HAS_MUSL_LIBC) -typedef unsigned short mask; -#else typedef unsigned long mask; -#endif static

[PATCH] D14926: Use libcxx's default rune table with the Musl C library.

2015-11-23 Thread Vasileios Kalintiris via cfe-commits
vkalintiris created this revision. vkalintiris added reviewers: mclow.lists, jroelofs, EricWF, dalias. vkalintiris added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. Also, there are no exported character type tables from Musl so we have to Fallback to the s