[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG744b111434b2: [clangd] Bail gracefully if given an assembly or IR source file (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge updated this revision to Diff 551694. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149236/new/ https://reviews.llvm.org/D149236 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-ex

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D149236#4597600 , @nridge wrote: > Adding Sam, since you're on a review roll ;) back from vacation :-) Comment at: clang-

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge added a reviewer: sammccall. nridge added a comment. Adding Sam, since you're on a review roll ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149236/new/ https://reviews.llvm.org/D149236 ___ cfe

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge added a comment. Review ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149236/new/ https://reviews.llvm.org/D149236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:859 + // The rest is a simplified version of TestTU::build(). + // Don't call TestTU::build() itself because it would assert on + // failure to build an AST. (I cou

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge created this revision. nridge added reviewers: hokein, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The previous