[PATCH] D149165: [clangd] Deduplicate missing-include findings

ArturGainullin added a comment. In D149165#4309463 , @kadircet wrote: > Thanks @ArturGainullin ! you're right, i've sent out > 5e74a3dc2da879d98204f2360e2e33571b93b91b > . @kadircet T

[PATCH] D149165: [clangd] Deduplicate missing-include findings

kadircet added a comment. Thanks @ArturGainullin ! you're right, i've sent out 5e74a3dc2da879d98204f2360e2e33571b93b91b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149165/new

[PATCH] D149165: [clangd] Deduplicate missing-include findings

ArturGainullin added a comment. Hello! After this change IncludeCleaner.GenerateMissingHeaderDiags unit test from ClangdTests.exe is failing on Windows for Debug build. Could you please take a look. It looks like error appears because comparator doesn't satisfy strict weak ordering. I.e. it fa

[PATCH] D149165: [clangd] Deduplicate missing-include findings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f0725a3a54: [clangd] Deduplicate missing-include findings (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149165: [clangd] Deduplicate missing-include findings

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:419 }); + // Put possibly equal diagnostics together for deduplication. + // The duplicates might be from macro arguments that get expanded

[PATCH] D149165: [clangd] Deduplicate missing-include findings

kadircet updated this revision to Diff 517076. kadircet added a comment. - Reorganize string literals in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149165/new/ https://reviews.llvm.org/D149165 Files: clang-tools-extra/clangd/IncludeClea

[PATCH] D149165: [clangd] Deduplicate missing-include findings

VitaNuo added a comment. Thank you! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:419 }); + // Put possibly equal diagnostics together for deduplication. + // The duplicates might be from macro arguments that get expanded multiple Could you m

[PATCH] D149165: [clangd] Deduplicate missing-include findings

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: