This revision was automatically updated to reflect the committed changes.
Manna marked 3 inline comments as done.
Closed by commit rG4faf3fcf3fb2: [NFC][CLANG] Fix coverity remarks about large
copy by values (authored by Manna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
Manna marked 4 inline comments as done.
Manna added inline comments.
Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:128
-bool containsNonScalarVarargs(CodeGenFunction *CGF, CallArgList Args) {
+bool containsNonScalarVarargs(CodeGenFunction *CGF, const CallArgList &Args) {
re
tahonermann accepted this revision.
tahonermann added a comment.
This revision is now accepted and ready to land.
These changes all look good to me. For the `DeclaratorChunk` case, I noted an
additional removal of a comment that I think should be considered. Assuming I
haven't misread the code,
Manna updated this revision to Diff 517018.
Manna edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149163/new/
https://reviews.llvm.org/D149163
Files:
clang/lib/CodeGen/CGGPUBuiltin.cpp
clang/lib/CodeGen/CGNonTrivialStruct.cpp
clang/lib/CodeGen/Cod
Manna updated this revision to Diff 517010.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149163/new/
https://reviews.llvm.org/D149163
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang/include/clang/Sema/CodeCompleteConsumer.h
clang/lib/CodeGen/CodeGenModule.cpp
clang/lib/Co
Manna updated this revision to Diff 516883.
Manna added a comment.
Herald added a subscriber: kadircet.
Herald added a project: clang-tools-extra.
Fix bot failures
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149163/new/
https://reviews.llvm.org/D149163
Files:
clang-tools-extra/clan
Manna updated this revision to Diff 516834.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149163/new/
https://reviews.llvm.org/D149163
Files:
clang/include/clang/Sema/CodeCompleteConsumer.h
clang/lib/CodeGen/CGGPUBuiltin.cpp
clang/lib/CodeGen/CGNonTrivialStruct.cpp
clang/lib/Code
Manna created this revision.
Manna added a reviewer: tahonermann.
Herald added a subscriber: arphaman.
Herald added a project: All.
Manna requested review of this revision.
Herald added a project: clang.
Reported By Static Analyzer Tool, Coverity:
Big parameter passed by value
Copying large value
