[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ab76b77cee0: [AArch64][InlineAsm]Add Clang support for flag output constraints (authored by mingmingl). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149123/new/ https://reviews.llvm.org/D149123 ___ cfe

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl added a comment. In D149123#4294619 , @mingmingl wrote: > While testing this patch with `./bin/clang -cc1 -S -triple=aarch64 > inline-asm-aarch64-flag-output.c` (which invokes global-isel for instruction > selection according to `print-after-a

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl updated this revision to Diff 517062. mingmingl marked 3 inline comments as done. mingmingl edited the summary of this revision. mingmingl added a comment. update on the crashing issue (solved) resolve comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149123/new/ https:

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:1216 +// Returns the length of cc constraint. +static unsigned matchAsmCCConstraint(const char *&Name) { + constexpr unsigned len = 5; davidxl wrote: > Name is not modified in

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

davidxl added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:1216 +// Returns the length of cc constraint. +static unsigned matchAsmCCConstraint(const char *&Name) { + constexpr unsigned len = 5; Name is not modified in this method, so perhaps

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl added a comment. While testing this patch with `./bin/clang -cc1 -S -triple=aarch64 inline-asm-aarch64-flag-output.c` (which invokes global-isel for instruction selection according to `print-after-all` output), turns out GlobalISel doesn't support flag output yet (for x86 or aarch64).

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl updated this revision to Diff 516640. mingmingl edited the summary of this revision. mingmingl added reviewers: dmgreen, nickdesaulniers, efriedma. mingmingl added a comment. remove 'No newline at end of file' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149123/new/ https://r

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl created this revision. Herald added subscribers: mstorsjo, kristof.beyls. Herald added a project: All. mingmingl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before: - Clang emits 'invalid output constraint error' https://gcc