[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

This revision was automatically updated to reflect the committed changes. Closed by commit rG38ecb9767c14: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://re

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna added a comment. In D149074#4293543 , @tahonermann wrote: > Looks good to me Thank you @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me, thanks @Manna! Comment at: clang/utils/TableGen/NeonEmitter.cpp:392 -for (auto Type : Types) { +for (const auto &Type : Types) {

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:4662 - for (auto KNPair : KnownNamespaces) + for (const auto &KNPair : KnownNamespaces) Namespaces.addNameSpecifier(KNPair.first); tahonermann wrote: > The element type is a pair of `

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:392 -for (auto Type : Types) { +for (const auto &Type : Types) { // If this builtin takes an immediate argument, we need to #define it rather tahonermann wrote: > The

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna updated this revision to Diff 516488. Manna marked 7 inline comments as done. Manna edited the summary of this revision. Manna added a comment. I have addressed @tahonermann review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

tahonermann added a comment. I added a comment to skip the one where the element type is a simple pair. The rest look fine to me. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:182 // Skip methods in records. -for (auto P : Context.getParents(*Method))

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna updated this revision to Diff 516445. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h clang/lib/AST/ComputeDependence.cpp clang/lib/

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: kosarev, tpr. Herald added a reviewer: aaron.ballman. Herald added a reviewer: ributzka. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDevelo