[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-24 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf66576016290: [Clang] Accept and forward `-fconvergent-functions` in the driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D149019?vs=516188&id=516400#toc Repository: rG

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 516188. jhuber6 added a comment. Remove cc1 negative option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149019/new/ https://reviews.llvm.org/D149019 Files: clang/include/clang/Driver/Options.td clang/lib

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:972 + LangOpts<"ConvergentFunctions">, DefaultFalse, + NegFlag, + PosFlag>; Only one of the positive and negative options need to be a cc1 option. Comment at: c

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-23 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149019/new/ https://reviews.llvm.org/D149019 __

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 516167. jhuber6 added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149019/new/ https://reviews.llvm.org/D149019 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Tool

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D149019#4290573 , @JonChesterfield wrote: > Can't reasonably see the semantic change between all the whitespace reformat, > please split those two. E.g. use git-clang-format to only fix formatting in > the part you're changi

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-23 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Can't reasonably see the semantic change between all the whitespace reformat, please split those two. E.g. use git-clang-format to only fix formatting in the part you're changing, or commit a clang-format only change first and then rebase this. Repository: r

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

2023-04-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, tianshilei1992, MaskRay, jdoerfert. Herald added subscribers: kosarev, abrachet, phosek, kerbowa, s.egerton, simoncook, asb, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Heral