This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f96ce5e133b: [clang-repl] Fix dynamic library test to avoid
cstdio and linker (authored by argentite).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148992/
sgraenitz accepted this revision.
sgraenitz added a comment.
Thanks. LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148992/new/
https://reviews.llvm.org/D148992
___
cfe-commits mailing list
cfe-commi
argentite updated this revision to Diff 516715.
argentite marked an inline comment as done.
argentite added a comment.
extern "C" and enable PS4/5
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148992/new/
https://reviews.llvm.org/D148992
Files:
sgraenitz added inline comments.
Comment at: clang/test/Interpreter/dynamic-library.cpp:12
+// return 5;
+// }
Should we wrap this in a `extern "C"` block? Otherwise, the shared library has
a C++ interface, which is not stable. It won't matter in this simple
zhuhan0 accepted this revision.
zhuhan0 added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148992/new/
https://reviews.llvm.org/D148992
argentite created this revision.
Herald added a project: All.
argentite added reviewers: bcain, zhuhan0, sgraenitz, v.g.vassilev.
argentite published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Some platforms do not have a working linker present
