This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6cf14a72390f: [clang][Interp] Check Neg ops for errors
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D148987?vs=517054&
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a request to add a message to the assertion.
Comment at: clang/lib/AST/Interp/Interp.h:436
+
+ assert(isIntegralType(Name));
S.Stk.push(Result);
-
tbaeder updated this revision to Diff 517054.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148987/new/
https://reviews.llvm.org/D148987
Files:
clang/lib/AST/Interp/Integral.h
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/PrimType.h
clang/test/AST/Interp/literals.cpp
Index
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:438-441
+ // FIXME: This code Just Works[tm] for floats, but it's probably not doing
+ // the right thing. At least the diagnostic could be better without
+ // the conversion to an APInt.
+
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:438-441
+ // FIXME: This code Just Works[tm] for floats, but it's probably not doing
+ // the right thing. At least the diagnostic could be better without
+ // the conversion to an APInt.
+
--
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:438-441
+ // FIXME: This code Just Works[tm] for floats, but it's probably not doing
+ // the right thing. At least the diagnostic could be better without
+ // the conversion to an APInt.
+
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I'm not sure what to do with the float case here, m
