[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-06-24 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit updated this revision to Diff 534244. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148958/new/ https://reviews.llvm.org/D148958 Files: clang/test/Analysis/malloc.mm clang/test/Analysis/uninit-vals.m clang/test/CodeGen/alloc-size.c compiler-rt/lib/profile/InstrProfil

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-06-24 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit updated this revision to Diff 534242. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148958/new/ https://reviews.llvm.org/D148958 Files: clang/test/Analysis/malloc.mm clang/test/Analysis/uninit-vals.m clang/test/CodeGen/alloc-size.c compiler-rt/lib/profile/InstrProfil

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D148958#4288782 , @vzakhari wrote: > In D148958#4288728 , @MaskRay wrote: > >> This is an unnecessary change. The arguments are interchangeable. >> In musl, there are at least 2 places

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Slava Zakharin via Phabricator via cfe-commits
vzakhari added a comment. In D148958#4288728 , @MaskRay wrote: > This is an unnecessary change. The arguments are interchangeable. > In musl, there are at least 2 places where the parameters could be swapped, > but I not unsure this warrants a commit. I

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This is an unnecessary change. In musl, there are at least 2 places where the parameters could be swapped, but I not unsure this warrants a commit. Repository: rG LLVM Github Mo

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

2023-04-21 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: MaskRay. Herald added a subscriber: Enna1. Herald added projects: Flang, All. gAlfonso-bit requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, jdoerfert. Herald added projects: clang, Sanitizers. T