[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-24 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/include/clang/Basic/Module.h:744-747 - submodule_iterator submodule_begin() { return SubModules.begin(); } - submodule_const_iterator submodule_begin() const {return SubModules.begin();} - submodule_iterator submodule_end()

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-24 Thread Sviatoslav Osipov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG40136ecefc0a: [clang] Make access to submodules via `iterator_range` (authored by Stoorx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https:/

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Sviatoslav Osipov via Phabricator via cfe-commits
Stoorx added a comment. Can you commit it? I have no commit access. Stoorx me[at]stoorx.one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Sviatoslav Osipov via Phabricator via cfe-commits
Stoorx updated this revision to Diff 515892. Stoorx added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/ https://reviews.llvm.org/D148954 Files: clang-tools-extra/modularize/CoverageChecker.cpp clang-tools-extra/modularize/ModularizeUtilities.cpp clan

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

2023-04-21 Thread Sviatoslav Osipov via Phabricator via cfe-commits
Stoorx created this revision. Herald added a project: All. Stoorx requested review of this revision. Herald added projects: clang, clang-tools-extra. In file `clang/lib/Basic/Module.cpp` the `Module` class had `submodule_begin()` and `submodule_end()` functions to retrieve corresponding iterators