This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
tbaeder marked an inline comment as done.
Closed by commit rG80fda7a34663: [clang][Sema][NFC] Make a bunch of things
const if possible (authored by tbaeder).
Changed p
tbaeder marked 5 inline comments as done.
tbaeder added inline comments.
Comment at: clang/lib/Sema/SemaLookup.cpp:1337
if (S->isClassScope())
-if (CXXRecordDecl *Record =
-dyn_cast_or_null(S->getEntity()))
+if (auto *Record = dyn_cast_if_pr
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Changes generally LGTM though I spotted a few places where we might as well
update to `auto` and one place where I think a `const` was missed.
Comment at: clan
tbaeder updated this revision to Diff 514933.
Herald added a reviewer: jdoerfert.
Herald added subscribers: jplehr, sstefan1.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148696/new/
https://reviews.llvm.org/D148696
Files:
clang/include/clang/AST/DeclarationName.h
clang/include/clan
tbaeder updated this revision to Diff 514878.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148696/new/
https://reviews.llvm.org/D148696
Files:
clang/include/clang/AST/DeclarationName.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/DeclarationName.cpp
clang/lib/Sema/Sema.cpp
cl
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
NFC but uploading for review for the pre-commit CI and maybe some actual rev
