[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

This revision was automatically updated to reflect the committed changes. Closed by commit rGe52a8b89adda: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna added a comment. In D148639#4284085 , @tahonermann wrote: > This set of changes looks good to me. Thank you @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/ https://reviews.llvm.org/D148639 ___

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna marked an inline comment as done. Manna added a comment. @aaron.ballman, do you have any more concerns or comments? Thank you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/ https://reviews.llvm.org/D148639 ___ cfe-commits mai

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This set of changes looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/ https://reviews.llvm.org/D148639 ___

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna marked 7 inline comments as done. Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9426 } else { for (auto IvarPair : DuplicateIvars) { Diag(IvarPair.first->getLocation(), tahonermann wrote: > aaron.b

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna updated this revision to Diff 515318. Manna added a comment. Thank you everyone for reviews and feedbacks. I misunderstood some of the False positive Coverity cases. Thanks for the explanation and suggestions. I will keep this in mind while investigating static analysis in future. This pat

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1053 - for (auto I : CleanedState->get()) { + for (const auto &I : CleanedState->get()) { if (SymbolRef Sym = I.second.getAsSymbol()) I think this is supposed to be

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

tahonermann added a comment. After seeing this review, I filed a support case with Synopsys with a request to stop reporting `AUTO_CAUSES_COPY` issues for small objects of class types, at least in the absence of additional evidence that a reference would be preferred. Commen

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

aaron.ballman added a comment. Thanks for the static analysis fixes, however, it looks like quite a few of them were false positives again. When fixing any static analysis diagnostics, please put in the effort to determine whether it's actually correct or not, as it seem the Coverity diagnostic

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna created this revision. Manna added reviewers: tahonermann, aaron.ballman. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, kristof.beyls. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested