[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

DavidSpickett added a comment. I'd suggest rewording the title a bit: `[clang] Return std::unique_ptr from AllocateTarget` Titles are always weird but at least including the function name means someone staring at a build failure can skim for likely commits. It's not always possible though. Sa

[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

Stoorx added a comment. Yes, it fails locally even for clean repository. I mean, just cloned main branch and tested immediately without any changes. I have found another review, which has the same tests failed. https://reviews.llvm.org/D148546 Moreover, you (@DavidSpickett) have already commen

[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

DavidSpickett added a comment. > That's my first commit into LLVM project. (Almost just for test of the > contribution procedure.) Welcome! > Maybe I did something wrong, but the build fails on example tests. Do the tests fail locally? I will look at the pre-commit logs as well. It may be fai

[PATCH] D148574: [clang] Use the 'std::unique_ptr' instead of a raw pointers

Stoorx added a comment. That's my first commit into LLVM project. (Almost just for test of the contribution procedure.) Maybe I did something wrong, but the build fails on example tests. I wonder, whether this review request will be actually reviewed despite the failed condition? And maybe som