[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

2023-04-17 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG488a4b24817a: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37 (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github Monore

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

2023-04-17 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D148496#4274352 , @browneee wrote: > Issue appears to be with the program rather than the instrumentation. Did the > behavior of the the libc functions used in the test change? If the question was directed at me, then I'm afra

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

2023-04-17 Thread Andrew via Phabricator via cfe-commits
browneee accepted this revision. browneee added a comment. LGTM `release_shadow_space.c:29: size_t get_rss_kb(): Assertion ```feof(f)' failed.` `custom.cpp:1858: void test_sprintf(): Assertion ```strcmp(buf, "Hello world!") == 0' failed.` Issue appears to be with the program rather than the in

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

2023-04-16 Thread Sam James via Phabricator via cfe-commits
thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Yes, please. Obviously we want to fix it properly but right now it's a known issue and it's noise when checking for regressions weekly. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

2023-04-16 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: browneee, vitalybuka, MaskRay, thesamesam, jianzhou.zh. Herald added subscribers: Enna1, dberris. Herald added a project: All. mgorny requested review of this revision. Mark the two dfsan tests that are known to be broken on glibc-2.37 as XFAIL