[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. > What is left for this to be reverted, in the quest to fully enable IAS for > AIX? See `XCOFFAsmParser::ParseDirectiveCSect()` and I think qual symbol names in AIX assembly(quite common for AIX assembly) can also not be parsed with llvm's asm parser. Repository: r

[PATCH] D148490: [AIX] use system assembler for assembly files

brad added a comment. What is left for this to be reverted, in the quest to fully enable IAS for AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-co

[PATCH] D148490: [AIX] use system assembler for assembly files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b27ad735c8d: [AIX] use system assembler for assembly files (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D148490?vs=521233&id=528257#toc Repository: rG LLVM Github Monorep

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ shchenz wrote: > MaskRay wrote: > > shchenz wrote: > > > MaskRay

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > shchenz wrote: > > MaskRay wrote: > > > aix-as.c

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ shchenz wrote: > MaskRay wrote: > > aix-as.c will be more appropr

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > aix-as.c will be more appropriate. Do you mean w

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ aix-as.c will be more appropriate. Repository: rG LLVM Github

[PATCH] D148490: [AIX] use system assembler for assembly files

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. This looks reasonable to me, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added a comment. In D148490#4334476 , @shchenz wrote: >> I am not sure you need 6 RUN lines to test this. Whether a target uses >> integrated assembler has an existing test file and you can reuse that. > > I don't have strong prefer which one we

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. > I am not sure you need 6 RUN lines to test this. Whether a target uses > integrated assembler has an existing test file and you can reuse that. I don't have strong prefer which one we should use, a new file or reuse file. Since you point out, I change to reuse a legac

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz updated this revision to Diff 521233. shchenz added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/target-as.s

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/aix-assembler.s:23 + +// RUN: %clang %s -### -c 2>&1 -fno-integrated-as \ +// RUN: --target=powerpc-ibm-aix7.1.0.0 \ I am not sure you need 6 RUN lines to test this. Whether a target uses integ

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz updated this revision to Diff 517011. shchenz added a comment. address @qiucf comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/a

[PATCH] D148490: [AIX] use system assembler for assembly files

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:427 + Assembler.reset(buildAssembler()); +return Assembler.get(); + } I saw we have a `ToolChain::getAssemble()` method. Can we use that directly? Comment at

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz created this revision. shchenz added reviewers: hubert.reinterpretcast, nemanjai, PowerPC. shchenz added a project: LLVM. Herald added a project: All. shchenz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change to system