This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG82a90caa88fd: [clang-format] Correctly format goto labels
followed by blocks (authored by sstwcw).
Changed prior to commit:
https://reviews.llvm.o
sstwcw added a comment.
Is this patch accepted or rejected?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148484/new/
https://reviews.llvm.org/D148484
___
cfe-commits mailing list
cfe-commits@lists.llvm.
sstwcw marked 3 inline comments as done.
sstwcw added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:4525
-const FormatToken *Next = Right.getNextNonComment();
-if (!Next || Next->is(tok::semi))
return false;
MyDeveloperDay wrote:
sstwcw updated this revision to Diff 514249.
sstwcw added a comment.
- Remove change in line wrapping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148484/new/
https://reviews.llvm.org/D148484
Files:
clang/lib/Format/FormatToken.h
clang/lib/Fo
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:714
// are in a control flow statements as well as several style flags.
-if (Line.First->is(tok::kw_case) ||
+if (Line.First->is(tok::kw_case) || Line.Last->is(TT_GotoLa
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:4525
-const FormatToken *Next = Right.getNextNonComment();
-if (!Next || Next->is(tok::semi))
return false;
how is the semi case handled or is it not needed
Rep
sstwcw added inline comments.
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:714
// are in a control flow statements as well as several style flags.
-if (Line.First->is(tok::kw_case) ||
+if (Line.First->is(tok::kw_case) || Line.Last->is(TT_GotoLabelColon) ||
sstwcw created this revision.
sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel.
Herald added projects: All, clang, clang-format.
Herald added a subscriber: cfe-commits.
sstwcw requested review of this revision.
There doesn't seem to be an issue on GitHub. But previously
