[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5545f1bbd4e1: [clang-tidy][NFC] Split bugprone-exception-escape tests (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ http

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! > A lot of our test files uses macros to differentiate between specific C++ > standards, why not do that here too? It's not that easy, because the #ifdef lines do not remo

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added a comment. @isuckatcs Ifdefs are ugly, to avoid messing with multiple runs in same unit test, I decided to split into 2 test files (C++11 and above, and C++11,C++14). And to be honest this change does nothing for caching (zero impact), let me explain: `super_throws_again` alone

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

isuckatcs added a comment. > Yes, throw specifier is removed in C++17, split allows to support C++17 and > above in main test file A lot of our test files uses macros to differentiate between specific C++ standards, why not do that here too? There are only a few occurences of functions with `th

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added a comment. In D148458#4309010 , @isuckatcs wrote: > Do we really want to split these two functions apart to different test files? > Is this really NFC? Yes, `throw specifier` is removed in C++17, split allows to support C++17 and above i

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

isuckatcs added a comment. Do we really want to split these two functions apart to different test files? Is this really NFC? The way `ExceptionEscapeCheck` works is that it creates an `ExceptionAnalyzer` upon instantiation. //By the way upon looking at the constructor of the check I see that

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

isuckatcs added a comment. Do we really want to split these two functions apart to different test files? Is this really NFC? The way `ExceptionEscapeCheck` works is that it creates an `ExceptionAnalyzer` upon instantiation. //By the way upon looking at the constructor of the check I see that

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL updated this revision to Diff 518353. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ https://reviews.llvm.org/D148458 Files: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escap

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL updated this revision to Diff 516481. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ https://reviews.llvm.org/D148458 Files: clang-tools-extra/test/c

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-throw.cpp:4 +void throwing_throw_nothing() throw() { +// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: an exception may be thrown in function 'throwing_throw_nothing' whi

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL updated this revision to Diff 516139. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Formating fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ https://reviews.llvm.org/D148458 Files: clang-tools-ext

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-throw.cpp:4 +void throwing_throw_nothing() throw() { +// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: an exception may be thrown in function 'throwing_throw_nothing

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape.cpp:267 const derived *p = &d; -throw p; } catch(base *) { carlosgalvezp wrote: > I run into this often as well. If you don't want to ge

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape.cpp:267 const derived *p = &d; -throw p; } catch(base *) { I run into this often as well. If you don't want to get push back during

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Split tests files into noexcept and throw(). This is prepa