[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

2023-04-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor cleanup. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1165 +return visit(LV); + return false; tbaeder wr

[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

2023-04-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1165 +return visit(LV); + return false; Since complex types are arrays with two elements, we can't dereference them like normal. This change just ignore the dereference.

[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

2023-04-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I wanted to avoid adding too many opcodes for bitin