This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3d6d2ae6f490: [include-cleaner] Handle incomplete template
specializations (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SI
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:163
ElementsAre(Decl::ClassTemplatePartialSpecialization));
+ // Incomplete templates don't have a specific specialization associated.
+ EXPECT_THAT(testWalk(R
kadircet updated this revision to Diff 513173.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Update comments & test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148158/new/
https://reviews.llvm.org/D148158
Files:
clang-
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:85
// This is the underlying decl used by TemplateSpecializationType, can be
// null when ty
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Instantiation pattern is null for incomplete template types and using
sp