EricWF closed this revision.
EricWF added a comment.
Committted in r255162. Thanks.
http://reviews.llvm.org/D14814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
K-ballo added a comment.
> After that these changes LGTM. @K-ballo I'm happy to make the changes as I
> commit this if your OK with that?
@EricWF Go ahead, thank you!
http://reviews.llvm.org/D14814
___
cfe-commits mailing list
cfe-commits@lists.l
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
The only issue I have with this is that we should still test both code patchs
with clang so we can ensure the fallback implementation remains correct. I
would change
#if __has_builtin(__mak
majnemer added a comment.
@EricWF Yes, it will.
http://reviews.llvm.org/D14814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@majnemer Will the compiler emit diagnostics comparable to the static asserts
in the other implementation?
http://reviews.llvm.org/D14814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
majnemer added a comment.
This LGTM but @mclow.lists or @EricWF should give the final say-so.
http://reviews.llvm.org/D14814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
K-ballo created this revision.
K-ballo added reviewers: mclow.lists, EricWF, majnemer, rsmith.
K-ballo added a subscriber: cfe-commits.
Use the `__make_integer_seq` builtin, introduced by r252036, when available.
This allows for an incredibly fast `std::make_integer_sequence` implementation.
htt
