[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

2023-04-13 Thread Richard Sandiford via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d4d51f8f5a: [clang] Specify attribute syntax & spelling with a single argument (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

2023-04-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm updated this revision to Diff 512993. rsandifo-arm added a comment. Tweak initializer to avoid an MSVC error: https://godbolt.org/z/sMxsW8G8j Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102 F

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

2023-04-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Later patches show enough value to this, I'm OK with it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102 ___ cfe-commits ma

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

2023-04-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I'm not sold on the value of this patch, but I don't see any problems with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102 ___ c

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

2023-04-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf