[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. Just noting for posterity that we discussed this at last week's RISC-V sync-up call and I think the tentative conclusion (there weren't particularly strong views) was that experiments CSRs should really be gated by -menable-experimental-extensions, with the CSR names gated

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c1fa60b5f5: [RISCV] Add Smaia and Ssaia extensions support (authored by 4vtomat). Changed prior to commit: https://reviews.llvm.org/D148066?vs=516137&id=518634#toc Repository: rG LLVM Github Monore

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. FWIW, I've reviewed the CSR numbers vs the spec so LGTM from that perspective. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 ___ cfe-comm

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

reames added a comment. In D148066#4294924 , @kito-cheng wrote: >> My concern would be that as we don't gate CSR names on enabling the relevant >> extension, people could start using CSR names and encodings that could >> change, without opting in via -

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. In D148066#4294924 , @kito-cheng wrote: >> My concern would be that as we don't gate CSR names on enabling the relevant >> extension, people could start using CSR names and encodings that could >> change, without opting in via -men

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

kito-cheng added a comment. > My concern would be that as we don't gate CSR names on enabling the relevant > extension, people could start using CSR names and encodings that could > change, without opting in via -menable-experimental-extensions, perhaps not > realising that they're using the un

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat updated this revision to Diff 516137. 4vtomat added a comment. Resolved Alex's comment. Moved both of extensions to experimental. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 Files: clang/tes

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. In D148066#4262379 , @reames wrote: > I would be fine landing this as experimental before ratification. I see no > real downside to doing that My concern would be that as we don't gate CSR names on enabling the relevant extension,

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

reames added a comment. I would be fine landing this as experimental before ratification. I see no real downside to doing that, and would essentially leave it the judgement of the patch author as to whether just waiting until ratification or doing the extra work for staging as experimental is

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. This extension doesn't appear to be ratified but you've listed it in the table of ratified extensions and treated it as a ratified extension in RISCVISAInfo.cpp. I know that given we don't do checking for CSR names the distinction feels a bit academic, but I don't think thi

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat updated this revision to Diff 512655. 4vtomat added a comment. Resolved Kito's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 Files: clang/test/Preprocessor/riscv-target-features.c l

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

kito-cheng added a comment. You need to update `llvm/docs/RISCVUsage.rst` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 ___ cfe-commits mailing list cfe-

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kit