[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb133a4629a5: [clangd] Hover: Add CalleeArgInfo for constructor expressions (authored by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147847/ne

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147847/new/ https://reviews.llvm.org/D147847 ___

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:986 + const FunctionDecl *FD = nullptr; + llvm::SmallVector Args; + nridge wrote: > tom-anders wrote: > > Unfortunately, while CallExpr and CXXConstructExpr basically have the same

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders updated this revision to Diff 517994. tom-anders marked an inline comment as done. tom-anders added a comment. Use ArrayRef instead of SmallVector to avoid copy (also fix 2 typos in the comment below) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:986 + const FunctionDecl *FD = nullptr; + llvm::SmallVector Args; + tom-anders wrote: > Unfortunately, while CallExpr and CXXConstructExpr basically have the same > API for getting Ar

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders added a comment. (Note that this diff is stacked on D147846 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147847/new/ https://reviews.llvm.org/D147847 ___ c

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:986 + const FunctionDecl *FD = nullptr; + llvm::SmallVector Args; + Unfortunately, while CallExpr and CXXConstructExpr basically have the same API for getting Args, they're not re

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders created this revision. tom-anders added reviewers: nridge, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tool