This revision was automatically updated to reflect the committed changes.
Closed by commit rG2eb9cc76a6c0: [clangd] Handle destructors in DefineOutline
tweak (authored by njames93).
Changed prior to commit:
https://reviews.llvm.org/D147802?vs=511780&id=513644#toc
Repository:
rG LLVM Github M
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186-194
+ if (const auto *Destructor = llvm::dyn_cast(FD)) {
+if (auto Err = Declarati
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186-194
+ if (const auto *Destructor = llvm::dyn_cast(FD)) {
+if (auto Err = DeclarationCleanups.add(tooling::Replacement(
+SM, Destructor->getLocation(), 0,
+
njames93 updated this revision to Diff 511780.
njames93 added a comment.
Clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147802/new/
https://reviews.llvm.org/D147802
Files:
clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
njames93 created this revision.
njames93 added reviewers: kadircet, sammccall.
Herald added a subscriber: arphaman.
Herald added a project: All.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Fix
