[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

2023-04-11 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 512434. mboehme added a comment. Eliminate specific handling of delete expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147698/new/ https://reviews.llvm.org/D147698 Files: clang/lib/Analysis/FlowSe

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

2023-04-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. In D147698#4257698 , @mboehme wrote: > @gribozavr2 Just to make sure I understand you correctly here (before I make > any changes to the code): IIUC you recommend simply doing nothing on a delete > expression? (Your arguments

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

2023-04-11 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added a comment. @gribozavr2 Just to make sure I understand you correctly here (before I make any changes to the code): IIUC you recommend simply doing nothing on a delete expression? (Your arguments for this make sense to me, just want to double-check I understood correctly.) Reposit

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

2023-04-06 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:315 + /// `D` must currently be associated with a value. + void unsetChild(const ValueDecl &D) { +auto It = Children.find(&D); Modifying already-created values

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

2023-04-06 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To model the fact that values get deleted by a d