[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

2023-04-07 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. In D147580#4250232 , @shafik wrote: > I guess I should have waited till I saw: https://reviews.llvm.org/D147673 Yeah, sorry about that. I realized that I still needed to add the testcase before continuing. :-) Repository: rG LL

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

2023-04-06 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. I guess I should have waited till I saw: https://reviews.llvm.org/D147673 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147580/new/ https://reviews.llvm.org/D147580 ___ cfe-commit

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

2023-04-06 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. I guess this is prep work for tackling unifying them later on as you attempted in https://reviews.llvm.org/D140584 I knew this is not exactly the same change but can you add the test case identified in https://github.com/llvm/llvm-project/issues/61118 and https://github

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

2023-04-05 Thread Bill Wendling via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfee6f114236: [Clang][NFC] Refactor "Designators" to be more similar (authored by void). Changed prior to commit: https://reviews.llvm.org/D147580