Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL253551: PR10235: support for vector mode attributes + warning, by Dmitry Polukhin. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14744?vs=40506&id=40618#toc Repository: rL

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks, this LGTM! ~Aaron http://reviews.llvm.org/D14744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

DmitryPolukhin updated this revision to Diff 40506. DmitryPolukhin marked 3 inline comments as done. http://reviews.llvm.org/D14744 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp test/Sema/attr-mode-vector-types.c Index

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

DmitryPolukhin added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:3315 @@ +3314,3 @@ + llvm::APInt VectorSize(64, 0); + if (Str.size() >= 4 && Str[0] == 'V') { +// Minimal length of vector mode is 4: 'V' + NUMBER(>=1) + TYPE(>=2). aaron.ballman wro

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

aaron.ballman added a comment. In http://reviews.llvm.org/D14744#291663, @DmitryPolukhin wrote: > Added new warning group as suggested. > > I see thousands of vector types in headers on GitHub > https://github.com/search?p=1&q=%22__attribute__+mode+v4sf%22+extension%3Ah&ref=searchresults&type=Co

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

DmitryPolukhin updated this revision to Diff 40489. DmitryPolukhin added a comment. Added new warning group as suggested. I see thousands of vector types in headers on GitHub https://github.com/search?p=1&q=%22__attribute__+mode+v4sf%22+extension%3Ah&ref=searchresults&type=Code&utf8=%E2%9C%93 l

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2765 @@ +2764,3 @@ +def warn_vector_mode_deprecated : Warning< + "specifying vector types with __attribute__ ((mode)) is deprecated, " + "use __attribute__ ((vector_size)) instead">,

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

DmitryPolukhin added a comment. Thank you for prompt response! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2765 @@ +2764,3 @@ +def warn_vector_mode_deprecated : Warning< + "specifying vector types with __attribute__ ((mode)) is deprecated, " + "use __attribute__ ((v

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

aaron.ballman added a comment. I am a little bit confused -- this patch adds a deprecation warning for vector sizes and claims that the attribute is ignored (by placing it in the IgnoredAttributes group), but then provides the initial implementation for this functionality and makes use of the a

[PATCH] D14744: PR10235: support for vector mode attributes + warning

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: aaron.ballman. DmitryPolukhin added a subscriber: cfe-commits. Add support for vector mode attributes like "__attribute__((mode(V4SF)))". Also add warning about deprecated vector modes like GCC does. http://reviews.llvm.org/D