[PATCH] D147422: [clang-format] NFC Document the other space before colon option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8385ee05e59d: [clang-format] NFC Document the other space before colon option (authored by sstwcw). Changed prior to commit: https://reviews.llvm.

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

owenpan added a comment. In D147422#4242115 , @sstwcw wrote: > It looks like a line break gets inserted in arrays. Does that mean the > option doesn't affect arrays? It matters only if `BreakArrays` is set to false. Repository: rG LLVM Github Monor

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

owenpan added a comment. In D147422#4240024 , @MyDeveloperDay wrote: > In D147422#4240021 , @owenpan wrote: > >> Should we extend `SpacesInContainerLiterals` so that it controls JSON colons >> too? If yes, then

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

sstwcw added a comment. In D147422#4240024 , @MyDeveloperDay wrote: > In D147422#4240021 , @owenpan wrote: > >> Should we extend `SpacesInContainerLiterals` so that it controls JSON colons >> too? If yes, then w

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

MyDeveloperDay added a comment. In D147422#4239701 , @Herald wrote: > NOTE: Clang-Format Team Automated Review Comment > > It looks like your clang-format review does not contain any unit tests, > please try to ensure all code changes have a unit test (u

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

MyDeveloperDay added a comment. In D147422#4240021 , @owenpan wrote: > Should we extend `SpacesInContainerLiterals` so that it controls JSON colons > too? If yes, then we don't need `SpaceBeforeJsonColon`. Otherwise, IMO we > should leave the doc alone.

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

owenpan added a comment. Should we extend `SpacesInContainerLiterals` so that it controls JSON colons too? If yes, then we don't need `SpaceBeforeJsonColon`. Otherwise, IMO we should leave the doc alone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added subscribers: cfe-commits, JDevlieghere. Herald added projects: All, clang, clang-format. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team