[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

2023-05-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. This PR seems related to this crash: https://github.com/llvm/llvm-project/issues/62958 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

2023-04-19 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D147307#4279337 , @jyu2 wrote: > This change seems cause assert: > > https://godbolt.org/z/z9G87Wr37 I can reproduce, investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

2023-04-18 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. This change seems cause assert: https://godbolt.org/z/z9G87Wr37 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing l

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

2023-04-13 Thread serge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8745c252bc: [clang] Do not require GNUInlineAttr for inline builtins (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

2023-04-12 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing list cfe-commi

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

2023-04-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 510752. serge-sans-paille retitled this revision from "[clang] Consider artificial always inline builtin as inline builtins" to "[clang] Do not require GNUInlineAttr for inline builtins". serge-sans-paille added a comment. DO not require gnu inline