This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2ba88443b31a: Fix an assertion failure in unwrapSugar
(authored by ahatanak).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
ahatanak updated this revision to Diff 513010.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Simplify test case and move it to clang/test/SemaCXX/sugar-common-types.cpp.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147263/new
mizvekov accepted this revision.
mizvekov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147263/new/
https://reviews.llvm.org/D147263
___
mizvekov added inline comments.
Comment at: clang/test/SemaObjCXX/arc-objc-lifetime.mm:69-79
+// See https://github.com/llvm/llvm-project/issues/61419
+
+template struct pair {
+ T0 first;
+ T1 second;
+};
+
I think the fix looks good, although this test may b
ahatanak added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147263/new/
https://reviews.llvm.org/D147263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
ahatanak created this revision.
ahatanak added reviewers: mizvekov, arphaman, fahad.
ahatanak added a project: clang.
Herald added a project: All.
ahatanak requested review of this revision.
An assertion in `Qualifiers::addObjCLifetime` fails when the ObjC lifetime bits
are already set.
Instead
