[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli added a comment. In D147209#4246622 , @leonardchan wrote: > In D147209#4245229 , @fpetrogalli > wrote: > >> In D147209#4244615 , @leonardchan >> wrote: >> >

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. In D147209#4245229 , @fpetrogalli wrote: > In D147209#4244615 , @leonardchan > wrote: > >> Hi. I think this led to some test failures on our builder at >> https://luci-milo.appspot.

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli added a comment. In D147209#4244615 , @leonardchan wrote: > Hi. I think this led to some test failures on our builder at > https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview: Hi @l

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings added a comment. It looks like the failing tests already go to some effort to set each of TMP, TEMP & TMPDIR so perhaps they should be simplified to just set CLANG_CRASH_DIAGNOSTICS_DIR instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. Hi. I think this led to some test failures on our builder at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview: Script: -- : 'RUN: at line 4'; rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/te

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

This revision was automatically updated to reflect the committed changes. Closed by commit rG029212617ca8: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147209

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. Looks useful, and matches the behaviour I would have expected anyway. The buildkite libcxx tests already rely on being able to pass this variable through, so the same seems d

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli created this revision. fpetrogalli added a reviewer: mizvekov. Herald added a project: All. fpetrogalli requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful for retriving crash reports of LIT runs when the temporary fo