PiotrZSL added a comment.
You right, I copied wrong issue id, should be #31825.
I do not plan to split this review. It's simply too big effort to do that, and
then maintain
multiple reviews that have dependencies on each other, they they all are
related to same check.
Repository:
rG LLVM Gi
carlosgalvezp added a comment.
You mention in the commit message that it fixes #25569, but that seems
unrelated (and is already closed)?
Personally I find it hard to review 2 github issue fixes + 1 NFC (moving the
assert code to assert.h) on the same patch, would it be possible to split to
hav
PiotrZSL updated this revision to Diff 509141.
PiotrZSL added a comment.
Fix auto
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147081/new/
https://reviews.llvm.org/D147081
Files:
clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:66
+
+ const auto *FuncDecl = CExpr->getDirectCallee();
+ if (!FuncDecl || !FuncDecl->getDeclName().isIdentifier())
PiotrZSL wrote:
> Eugene.Zelenk
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:66
+
+ const auto *FuncDecl = CExpr->getDirectCallee();
+ if (!FuncDecl || !FuncDecl->getDeclName().isIdentifier())
Eugene.Zelenko wrote:
> Please do not
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:66
+
+ const auto *FuncDecl = CExpr->getDirectCallee();
+ if (!FuncDecl || !FuncDecl->getDeclName().isIdentifier())
Please do not use `auto` if typ
PiotrZSL created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
- Fixed problem when af
