[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

This revision was automatically updated to reflect the committed changes. Closed by commit rGf099f2fefbab: [clangd] Use all inputs to SystemIncludeExtractor in cache key (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146941/new

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

nridge added a comment. In D146941#4264146 , @nridge wrote: > Do you have any thoughts on merging D147905 > first, with a view to backporting D147905 > to the 16.x branch? Since ther

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

kadircet updated this revision to Diff 513098. kadircet marked an inline comment as done. kadircet added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146941/new/ https://reviews.llvm.org/D146941 Files: clang-tools-extra/clan

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Do you have any thoughts on merging D147905 first, with a view to backporting D147905 to the 16.x branch?

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

kadircet updated this revision to Diff 513070. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146941/new/ https://reviews.llvm.org/D146941 Files: clang-tools-

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:80 + std::string Driver; + std::string Directory; + // Whether certain includes should be part of query. nridge wrote: >

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

nridge added inline comments. Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:80 + std::string Driver; + std::string Directory; + // Whether certain includes should be part of query. It looks like the purpose of including `Directory` in the key

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

kadircet created this revision. kadircet added a reviewer: nridge. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Instead of pass