apwadkar added inline comments.
Comment at: clang/lib/Format/BreakableToken.cpp:406
Decoration = "* ";
- if (Lines.size() == 1 && !FirstInLine) {
+ if ((Lines.size() == 1 && !FirstInLine) || !Style.DecorateReflowedComments) {
// Comments for which FirstInLine is false c
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/BreakableToken.cpp:406
Decoration = "* ";
- if (Lines.size() == 1 && !FirstInLine) {
+ if ((Lines.size() == 1 && !FirstInLine) || !Style.DecorateReflowedComments) {
// Comments for which FirstInLine
MyDeveloperDay added inline comments.
Comment at: clang/include/clang/Format/Format.h:2022
+ /// \version 17
+ bool DecorateReflowedComments;
+
you are not setting the default value for this so it could be uninitialized,
you need to set that in the LLVMStyle s
MyDeveloperDay added a comment.
no you need to run
clang/doc/tools/dump_format_style.py
This will regnerate ClangFormatStyleOptions.rst from the Format.h change you
have here, you then need to include that rst file in the review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
apwadkar added a comment.
Sorry about the premature review, this is my first commit, and I didn't realize
it wouldn't create a draft first.
- For rebuilding the docs, I assume I need to add `-DLLVM_BUILD_DOCS=true` to
CMake and then run `ninja -C build`?
Repository:
rG LLVM Github Monorepo
MyDeveloperDay added a comment.
You need to add unit tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146926/new/
https://reviews.llvm.org/D146926
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
MyDeveloperDay added a comment.
You need to regenerate the documentation after changing Format.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146926/new/
https://reviews.llvm.org/D146926
___
cfe-commits
apwadkar created this revision.
Herald added a project: All.
apwadkar requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Added the DecorateReflowComments option to control whether '* ' are added
to the beginnings of continuation lines for bloc
