Re: [PATCH] D14691: clang side of http://reviews.llvm.org/D14690

2015-12-02 Thread Rafael Ávila de Espíndola via cfe-commits
rafael abandoned this revision. rafael added a comment. In the end we changed only SetVector. http://reviews.llvm.org/D14691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14691: clang side of http://reviews.llvm.org/D14690

2015-12-02 Thread Chandler Carruth via cfe-commits
chandlerc added inline comments. Comment at: include/clang/Lex/HeaderSearchOptions.h:145 @@ -143,2 +144,3 @@ /// of computing the module hash. - llvm::SetVector ModulesIgnoreMacros; + llvm::SetVector, std::set> + ModulesIgnoreMacros; There is clearly a u

Re: [PATCH] D14691: clang side of http://reviews.llvm.org/D14690

2015-12-02 Thread Tom Stellard via cfe-commits
tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. AMDGPU changes LGTM. http://reviews.llvm.org/D14691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D14691: clang side of http://reviews.llvm.org/D14690

2015-11-15 Thread Rafael Ávila de Espíndola via cfe-commits
rafael created this revision. rafael added a reviewer: chandlerc. rafael added a subscriber: cfe-commits. Herald added a reviewer: tstellarAMD. http://reviews.llvm.org/D14691 Files: include/clang/Lex/HeaderSearchOptions.h include/clang/Sema/Sema.h lib/AST/VTableBuilder.cpp lib/CodeGen/CGO