[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 added a comment. In D146842#4271144 , @PiotrZSL wrote: > In D146842#4271089 , @njames93 > wrote: > >> I think this should be split up into 2 separate patches, one for each of the >> proposed changes and

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL added a comment. In D146842#4271089 , @njames93 wrote: > I think this should be split up into 2 separate patches, one for each of the > proposed changes and each can be reviewed on their own. I don't plan to split this. Repository: rG LLVM

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. Ok, taking a step back here, this patch is trying to address 2 unrelated things at once: - using `--dump-config` with bad check options results in a crash - using `--verify-confi

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:61-69 struct NamesAndOptions { llvm::StringSet<> Names; llvm::StringSet<> Options; + std::vector Errors; }; NamesAndOptions njames93 wrote: > I don't think this is th

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:61-69 struct NamesAndOptions { llvm::StringSet<> Names; llvm::StringSet<> Options; + std::vector Errors; }; NamesAndOptions I don't think this is the correct approach

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL updated this revision to Diff 513692. PiotrZSL added a comment. Ping + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146842/new/ https://reviews.llvm.org/D146842 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-ext

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently due to missin