[PATCH] D146801: [clang] Fix consteval initializers of temporaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG83c90e623a30: [clang] Fix consteval initializers of temporaries (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D146801?vs=508524&id=508963#toc Repository: rG LLVM Github M

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Precommit CI is still falling over because of the libcxx bot. That issue is being actively investigated, but we don't have an ETA on it being resolved. I think these changes are sufficiently safe to land and watch for pos

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon updated this revision to Diff 508524. Fznamznon added a comment. Rebase, maybe this will get "pre-commit" started Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146801/new/ https://reviews.llvm.org/D146801 Files: clang/docs/ReleaseNotes

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1593-1595 + if (ConstantExpr *CE = dyn_cast_or_null(Inner)) +if (CE->isImmediateInvocation()) + Inner = CE->getSubExpr(); Fznamznon wrote: > aaron.ballman wrote: > > This wi

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1593-1595 + if (ConstantExpr *CE = dyn_cast_or_null(Inner)) +if (CE->isImmediateInvocation()) + Inner = CE->getSubExpr(); aaron.ballman wrote: > This will need reformatting, but

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon updated this revision to Diff 508082. Fznamznon added a comment. Apply the suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146801/new/ https://reviews.llvm.org/D146801 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaEx

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM (though I had a small nit), but you should add a release note when landing. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1593-1595 + if (Consta

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a potential immediate invocation is met, it is immediately wrapped by a `ConstantExpr`. There is also a TreeTransfo