[PATCH] D146784: [clang] Test for AST Dumping of the template variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a9dc94d336a: [clang] Test for AST Dumping of the template variables (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorep

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508104. tomasz-kaminski-sonarsource added a comment. Reintroduced bug commit refernces. Sorry for the noise, but I still sometimes get confused with arc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508102. tomasz-kaminski-sonarsource added a comment. Reverted accidentally included changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 Files

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508091. tomasz-kaminski-sonarsource added a comment. Rebased on updated test commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 Files: clan

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508088. tomasz-kaminski-sonarsource added a comment. Updated FIXME with GitHub bug reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 File

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D146784#4219469 , @tomasz-kaminski-sonarsource wrote: > This is now tracked as https://github.com/llvm/llvm-project/issues/61680. Let

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource added a comment. This is now tracked as https://github.com/llvm/llvm-project/issues/61680. Let me know if I should refer it in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-dump-template-decls.cpp:193 +// DIRECT: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// SERIALIZED: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// CHECK-NEXT: `-Template

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/AST/ast-dump-template-decls.cpp:193 +// DIRECT: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// SERIALIZED: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// CHECK-NE

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 508076. tomasz-kaminski-sonarsource added a comment. Added FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 Files: clang/test/AST/ast-dump-

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

erichkeane added inline comments. Comment at: clang/test/AST/ast-dump-template-decls.cpp:193 +// DIRECT: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// SERIALIZED: VarTemplateSpecializationDecl 0x{{[^ ]*}} col:5 unTempl 'int' +// CHECK-NEXT: `-TemplateArg

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource updated this revision to Diff 507973. tomasz-kaminski-sonarsource added a comment. Merged indidictal check lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146784/new/ https://reviews.llvm.org/D146784 Files: clang/

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource added a comment. I do not plan to address the behavior in case of a variable without initializer. Creating separate PR to illustrate that is not a regression from my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

tomasz-kaminski-sonarsource created this revision. Herald added a project: All. tomasz-kaminski-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They illustrate unstable behavior of the https://reviews.llvm.org/D139705 after seri