[PATCH] D146758: Fix codegen for coroutine with function-try-block

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe00a8d081d78: Fix codegen for coroutine with function-try-block (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); + CompoundStmt *Body = dyn_cast(BodyStmt); + if (Body == nullptr) { +Body = +CompoundStmt::Create(getContext(), {BodyStmt}, FPOpt

[PATCH] D146758: Fix codegen for coroutine with function-try-block

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Since the patch itself is good and not large. Let me handle the trivial refactoring later. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); + CompoundStmt *Body = dyn_cast(BodyStmt); + if (Body == nullptr) { +Body = +CompoundStmt::Create(getContext(), {BodyStmt}, FPOpt

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB updated this revision to Diff 509173. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146758/new/ https://reviews.llvm.org/D146758 Files: clang/include/clang/AST/StmtCXX.h clang/lib/AST/ASTImporter.cpp clang/lib/AST/StmtCXX.cpp clang/li

[PATCH] D146758: Fix codegen for coroutine with function-try-block

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); + CompoundStmt *Body = dyn_cast(BodyStmt); + if (Body == nullptr) { +Body = +CompoundStmt::Create(getContext(), {BodyStmt}, FP

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB updated this revision to Diff 508792. MatzeB marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146758/new/ https://reviews.llvm.org/D146758 Files: clang/include/clang/AST/StmtCXX.h clang/lib/AST/ASTImporter.c

[PATCH] D146758: Fix codegen for coroutine with function-try-block

ChuanqiXu requested changes to this revision. ChuanqiXu added a comment. This revision now requires changes to proceed. Thanks for finding this! We didn't notice this before. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:724-730 + Stmt *BodyStmt = S.getBody(); + Compo

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB added inline comments. Comment at: clang/test/CodeGenCoroutines/coro-function-try-block.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple=x86_64-- -emit-llvm -fcxx-exceptions \ +// RUN:-disable-llvm-passes %s -o - | FileCheck %s bruno wrote: > Space

[PATCH] D146758: Fix codegen for coroutine with function-try-block

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! @ChuanqiXu wdyt? Comment at: clang/test/CodeGenCoroutines/coro-function-try-block.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple=x86_64-- -emit-llvm -fcxx-exceptions \ +//

[PATCH] D146758: Fix codegen for coroutine with function-try-block

MatzeB created this revision. MatzeB added reviewers: GorNishanov, EricWF, ChuanqiXu, bruno. Herald added subscribers: modimo, wenlei, martong, mcrosier. Herald added a reviewer: shafik. Herald added a project: All. MatzeB requested review of this revision. Herald added a project: clang. Herald add