[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481f88853685: [clangd] Use expansion location for missing include diagnostics. (authored by VitaNuo). Changed prior to commit: https://reviews.llv

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo added a comment. thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc}, true}, SM, AST.getLan

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508648. VitaNuo added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra/clan

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508645. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-too

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc}, true}, SM, AST.getLangOpts()); --

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc},

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc}, true}, SM, AST.getLangOpts()); --

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:382 -auto &Tokens = AST.getTokens(); -auto SpelledForExpanded = -Tokens.spelledForExpanded(Tokens.ex

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508586. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments. Use spelling locations for macro arguments, and expansion locations for everything else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:382 -auto &Tokens = AST.getTokens(); -auto SpelledForExpanded = -Tokens.spelledForExpanded(Tokens.expandedTokens(Ref.RefLocation)); -if (!SpelledForExpand

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 507748. VitaNuo added a comment. Remove unrelated diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-t

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http