[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

2023-05-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet abandoned this revision. kadircet added a comment. in favor of D149733 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146634/new/ https://reviews.llvm.org/D146634 _

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

2023-03-28 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 508934. kadircet added a comment. Herald added a project: clang-tools-extra. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146634/new/ https://reviews.llvm.org/D146634 Files: clang-tools-extra/cl

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

2023-03-27 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Hopefully this should be addressed by D146971 , but it would be great to get a reproducer for this issue to be ceratin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146634/new/ htt

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

2023-03-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D146634#4215754 , @kadircet wrote: > I am aware that this null checking at leaves are not considered a sustainable > solution and I agree with the sentiment there. But we're seeing an increasing > number of crashes in p

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

2023-03-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. I am aware that this null checking at leaves are not considered a sustainable solution and I agree with the sentiment there. But we're seeing an increasing number of crashes in production on invalid code recently. Happy to take a different course if there are alternati

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

2023-03-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to D146426 Repository: rG LLVM Github