This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
mboehme marked 2 inline comments as done.
Closed by commit rG0608541aa4b5: [clang][dataflow][NFC] Eliminate StmtToEnvMap
interface. (authored by mboehme).
Repository:
mboehme marked 2 inline comments as done.
mboehme added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:35
+ /// The result is guaranteed never to be null.
+ virtual const Environment *getEnvironment(const Stmt &S) const {
+auto BlockIt =
mboehme updated this revision to Diff 508916.
mboehme added a comment.
Changes in response to review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146507/new/
https://reviews.llvm.org/D146507
Files:
clang/include/clang/Analysis/FlowSens
mboehme updated this revision to Diff 508907.
mboehme added a comment.
Rebase to head
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146507/new/
https://reviews.llvm.org/D146507
Files:
clang/include/clang/Analysis/FlowSensitive/Transfer.h
clang
xazax.hun accepted this revision.
xazax.hun added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146507/new/
https://reviews.llvm.org/D146507
___
cfe-commits mailing list
cfe-commits@li
ymandel accepted this revision.
ymandel added a comment.
thanks!
Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:36-40
+auto BlockIt = CFCtx.getStmtToBlock().find(&ignoreCFGOmittedNodes(S));
+assert(BlockIt != CFCtx.getStmtToBlock().end());
+const
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:35
+ /// The result is guaranteed never to be null.
+ virtual const Environment *getEnvironment(const Stmt &S) const {
+auto BlockIt = CFCt
mboehme added a comment.
@gribozavr2 @xazax.hun Just wanted to confirm that you still regard this as
ready to land now that I've changed the patch as we discussed offline?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146507/new/
https://reviews.l
mboehme updated this revision to Diff 507297.
mboehme added a comment.
Pursue a less ambitious approach, as described in the previous comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146507/new/
https://reviews.llvm.org/D146507
Files:
clan
mboehme added a comment.
After some offline discussion with reviewers, we've come to the conclusion that
`AnalysisContext` isn't a sufficiently clear abstraction to warrant putting it
in a header.
For the time being, I'll therefore pursue the less ambitious approach of simply
eliminating the `
mboehme added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:31
- /// there isn't one.
- /// FIXME: Ensure that the result can't be null and return a const reference.
- virtual const Environment *getEnvironment(const Stmt &S) const = 0;
mboehme updated this revision to Diff 506913.
mboehme added a comment.
Add back comment that I inadvertently deleted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146507/new/
https://reviews.llvm.org/D146507
Files:
clang/include/clang/Analysis/
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:31
- /// there isn't one.
- /// FIXME: Ensure that the result can't be null and return a const
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Instead of `StmtToEnvMap`, we pass an `AnalysisC
14 matches
Mail list logo
