[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman added a comment. In D146497#4216278 , @Hahnfeld wrote: > In D146497#4216226 , @aaron.ballman > wrote: > >> The issue doesn't reproduce for me locally on my Windows machine, so it may >> be somethin

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

Hahnfeld added a comment. In D146497#4216226 , @aaron.ballman wrote: > The issue doesn't reproduce for me locally on my Windows machine, so it may > be something specific to the VE setup. FWIW I'm not doing anything specific for VE, just set(CMAKE_C

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman added a comment. In D146497#4216197 , @aaron.ballman wrote: > In D146497#4215650 , @Hahnfeld > wrote: > >> FYI this commit breaks `clang/test/Index/index-file.cu` for me: >> >> warning: CUDA vers

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman added a comment. In D146497#4215650 , @Hahnfeld wrote: > FYI this commit breaks `clang/test/Index/index-file.cu` for me: > > warning: CUDA version 11.8 is only partially supported > [-Wunknown-cuda-version] > warning: CUDA version 11.8

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

Hahnfeld added a comment. FYI this commit breaks `clang/test/Index/index-file.cu` for me: warning: CUDA version 11.8 is only partially supported [-Wunknown-cuda-version] warning: CUDA version 11.8 is only partially supported [-Wunknown-cuda-version] /home/jhahnfel/LLVM/src/clang/test/Inde

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

This revision was automatically updated to reflect the committed changes. Closed by commit rG201fdef40dd6: libclang: Pass Clang install directory to driver via argv[0]. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D146497?vs=506832&id=507525#toc Repository: rG LLVM Gi

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

pcc added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:4022 + llvm::sys::path::append(ClangPath, "bin"); + llvm::sys::path::append(ClangPath, "clang"); + pcc wrote: > aaron.ballman wrote: > > I suspect this doesn't matter *too* much, but... on W

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

pcc added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:4022 + llvm::sys::path::append(ClangPath, "bin"); + llvm::sys::path::append(ClangPath, "clang"); + aaron.ballman wrote: > I suspect this doesn't matter *too* much, but... on Windows, wouldn'

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a nit and a question, but can you add a release note when you land to let users know about the changes? Comment at: clang/tools/libclang/CIndex.cpp:4

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

pcc created this revision. pcc added reviewers: bkramer, aaron.ballman. Herald added subscribers: mikhail.ramalho, arphaman. Herald added a project: All. pcc requested review of this revision. Herald added a project: clang. Various driver features, such as the sysroot path detection for Android ta