[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

mstorsjo added a comment. In D146490#4307269 , @falhumai96 wrote: > I would like to follow up on this issue whether or not there has been an > update on it. There's no update currently; I think there's some amount of consensus that this approach, whil

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

falhumai96 added a comment. Hello devs, I would like to follow up on this issue whether or not there has been an update on it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146490/new/ https://reviews.llvm.org/D146490 __

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

mstorsjo added a comment. In D146490#4209495 , @aganea wrote: > Fair enough. There are several choices forward: either we mark the issue as > "Will Not Fix" or I can try only scoping this patch to only keep the handle > for network drives/paths. Any oth

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

kadircet added a comment. In D146490#4209495 , @aganea wrote: > Fair enough. There are several choices forward: either we mark the issue as > "Will Not Fix" or I can try only scoping this patch to only keep the handle > open for network drives/paths. An

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aganea added a comment. Fair enough. There are several choices forward: either we mark the issue as "Will Not Fix" or I can try only scoping this patch to only keep the handle for network drives/paths. Any other suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aaron.ballman added a comment. FWIW, I'm also nervous about this change. Keeping the file handle open changes the ways in which you can access the file from other processes (or within the same process), so I'd expect this to cause some heartache, possibly for downstreams as well as Clang users.

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

hans added a comment. This makes me nervous as well. I think it also doesn't fit well with developers' expectations of UniqueID, changing it from a simple piece of data to something which interacts with the OS in a pretty deep way. I don't have specific examples, but I'm sure it will bite us so

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

kadircet added a comment. > To fix the issue, we keep the file handles open during the lifetime of their > corresponding UniqueID instances. Since handles will live longer now, this > requires particular attention when performing some file actions, such as file > deletions. I am a little worri

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aganea updated this revision to Diff 506820. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146490/new/ https://reviews.llvm.org/D146490 Files: clang-tools-extra/clangd/unittests/FSTests.cpp clang/include/clang/

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aganea created this revision. aganea added reviewers: mstorsjo, hans, kbobyrev, dexonsmith, zero9178. Herald added subscribers: kadircet, arphaman, hiraditya. Herald added a project: All. aganea requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added s